Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use BuildKit heredocs #105

Merged
merged 3 commits into from
Sep 23, 2022
Merged

Conversation

MisterDA
Copy link
Contributor

@MisterDA MisterDA commented Jul 25, 2022

IMHO, this part of the syntax is harder to read than the original version. The {| |} introduces complexity by mixing ocaml and >> bash syntax instead of the run "cmd".

Originally posted by @maiste in #99 (comment)

Thank you for the review Etienne. I'd say the complexity is having to follow the file line-by-line through multiple RUN and echo > calls and that the code is more "readable", or at least that the file isn't being split and stands out in the OCaml as well as in the generated Dockerfile.
Since you don't share that opinion, but also that I think we can agree it's a minor change without much technical advantages, I'm going to split the commit using heredocs (even though it was the feature that motivated this change) from this PR so that maybe it can move forward.

Originally posted by @MisterDA in #99 (comment)

Copy link
Member

@tmcgilchrist tmcgilchrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small formatting change, otherwise it looks good.

src-opam/dockerfile_opam.ml Show resolved Hide resolved
@tmcgilchrist tmcgilchrist merged commit 4d2b89e into ocurrent:master Sep 23, 2022
@MisterDA MisterDA deleted the use-buildkit-heredocs branch September 23, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants